Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

[WIP] Migrate to N-API #105

Merged
merged 2 commits into from
Apr 27, 2021
Merged

[WIP] Migrate to N-API #105

merged 2 commits into from
Apr 27, 2021

Conversation

dennisameling
Copy link
Contributor

Inspired from atom/node-keytar#268, using https://github.com/nodejs/node-addon-api/blob/main/doc/conversion-tool.md

This is a very rough first commit that needs quite some work still!

@sergiou87
Copy link
Collaborator

sergiou87 commented Apr 15, 2021

Hey @dennisameling! 👋  Let me know if you need help with this, I might have time in the next days if needed 😄

I just did the same change in registry-js to practice and learn, so I might be helpful after all 🤣

@dennisameling
Copy link
Contributor Author

@sergiou87 would be great if you could have a look at this! Have just invited you to my fork so you can directly work on this branch! Otherwise I might have some time during the weekend to look into this 👍🏼

@sergiou87
Copy link
Collaborator

Awesome, thanks! I'll take a look tomorrow 😄

void ClearAuthorizationCache(const Nan::FunctionCallbackInfo<Value>& info) {
ClearAuthorizationCache();
Napi::Value ClearAuthorizationCache(const Napi::CallbackInfo& info) {
ClearAuthorizationCacheImpl();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiou87
Copy link
Collaborator

@dennisameling this should be good to go now! Take a look at the changes, please. I think they all make sense 😄  /cc @billygriffin

@sergiou87 sergiou87 merged commit 14946c3 into atom:master Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants